Omer Frenkel has posted comments on this change.

Change subject: engine: template support for cpu host
......................................................................


Patch Set 7: (1 inline comment)

what about import and export for this field?

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java
Line 768:         defaultDisplayType = value;
Line 769:     }
Line 770: 
Line 771:     @Column(name = "host_cpu_flags", nullable = false)
Line 772:     private boolean useHostCpuFlags;
please move field definition to head of class with other fields.
Line 773: 
Line 774:     public boolean isUseHostCpuFlags() {
Line 775:         return useHostCpuFlags;
Line 776:     }


--
To view, visit http://gerrit.ovirt.org/10205
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7da929baee0f4bb9e01ffd3d08989a7628d08743
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to