Maor Lipchuk has posted comments on this change.

Change subject: core,ui: support multiple concurrent disks migration
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskFinishTaskHandler.java
Line 53:             
ImagesHandler.updateImageStatus(getEnclosingCommand().getParameters().getDestinationImageId(),
Line 54:                     ImageStatus.OK);
Line 55:         }
Line 56:         else {
Line 57:             log.errorFormat("VmReplicateDiskFinishTaskHandler: Failed 
VmReplicateDiskFinish (Disk {0} , VM {1})",
Please remove VmReplicateDiskFinishTaskHandler: prefix
Line 58:                     
getEnclosingCommand().getParameters().getImageGroupID(),
Line 59:                     getEnclosingCommand().getParameters().getVmId());
Line 60:             throw new VdcBLLException(ret.getVdsError().getCode(), 
ret.getVdsError().getMessage());
Line 61:         }


....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/VmReplicateDiskStartTaskHandler.java
Line 35:         VDSReturnValue ret =
Line 36:                 
ResourceManager.getInstance().runVdsCommand(VDSCommandType.VmReplicateDiskStart,
 migrationStartParams);
Line 37: 
Line 38:         if (!ret.getSucceeded()) {
Line 39:             log.errorFormat("VmReplicateDiskStartTaskHandler: Failed 
VmReplicateDiskStart (Disk {0} , VM {1})",
Please remove VmReplicateDiskStartTaskHandler: prefix
Line 40:                     
getEnclosingCommand().getParameters().getImageGroupID(),
Line 41:                     getEnclosingCommand().getParameters().getVmId());
Line 42:             throw new VdcBLLException(ret.getVdsError().getCode(), 
ret.getVdsError().getMessage());
Line 43:         }


--
To view, visit http://gerrit.ovirt.org/10154
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iadcffa5748b58b1af40535b0447487dde6c2d6cb
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to