Alona Kaplan has posted comments on this change.
Change subject: restapi: Vnic's network update when portMirroring is set
behaves wrong
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
Line 53: @Override
Line 54: public NIC update(NIC device) {
Line 55: //TODO: this is temporary mapping between engine boolean port
mirroring parameter, and REST
Line 56: // port mirroring network collection, next engine version
will support the network collection
Line 57: // in port mirroring
Done
Line 58: if (device.isSetPortMirroring() || device.isSetNetwork()) {
Line 59: validatePortMirroring(device);
Line 60: }
Line 61:
Line 63: }
Line 64:
Line 65: private void validatePortMirroring(NIC device) {
Line 66: NIC nic = null;
Line 67: validateEnums(NIC.class, device);
Done
Line 68: boolean fault = false;
Line 69: String faultString = "The port mirroring network must match
the Network set on the NIC";
Line 70: Network pmNetwork = null;
Line 71:
--
To view, visit http://gerrit.ovirt.org/10441
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icbb346805f91bd3964550a19b18b3d0a0c40e12c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
