Alona Kaplan has posted comments on this change.
Change subject: webadmin: Avoid duplicate server [Search] queries
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalLoginModel.java
Line 357: // Create a list of ActionGroups associated with the user by
retrieving each role's ActionGroups (and proceed to
Line 358: // Step4).
Line 359: // Use only as 'Step3' of 'UpdateIsENGINEUser'
Line 360: public void UpdateUserActionGroups(Object targetObject,
ArrayList<Guid> roleIdList)
Line 361: {
The change in this class is not related to the patch. Please split to another
patch.
Line 362: ArrayList<VdcQueryParametersBase> queryParamsList =
Line 363: new ArrayList<VdcQueryParametersBase>();
Line 364: ArrayList<VdcQueryType> queryTypeList = new
ArrayList<VdcQueryType>();
Line 365: for (Guid roleId : roleIdList) {
--
To view, visit http://gerrit.ovirt.org/9554
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I483a1c449f1eb2e9820464dbaf0a686f90923bb6
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
