Tal Nisan has posted comments on this change.
Change subject: webadmin: Disks sub-tab under Storage main-tab
......................................................................
Patch Set 3: Looks good to me, approved
(2 inline comments)
Minor comments, not mandatory
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDiskListModel.java
Line 108:
Line 109: StorageDomainQueryParametersBase parameters =
Line 110: new
StorageDomainQueryParametersBase((getEntity()).getId());
Line 111: parameters.setRefresh(getIsQueryFirstTime());
Line 112: Frontend.RunQuery(VdcQueryType.GetAllDisksByStorageDomainId,
parameters, query);
I personally like to have the RunQuery and create the call back anonymous class
all in the same statement, that way you can see right away which query is
executed instead of looking after the callback to see what happens, matter of
style I guess but you might want to consider it
Line 113: }
Line 114:
Line 115: private void updateActionAvailability() {
Line 116: ArrayList<DiskImage> disks = getSelectedItems() != null ?
Line 113: }
Line 114:
Line 115: private void updateActionAvailability() {
Line 116: ArrayList<DiskImage> disks = getSelectedItems() != null ?
Line 117: Linq.<DiskImage> Cast(getSelectedItems()) : new
ArrayList<DiskImage>();
Can't we just cast the selected items directly to List<DiskImage>? The linq
creates a new list and copies the values, seems expensive
Line 118:
Line 119: getRemoveCommand().setIsExecutionAllowed(disks.size() > 0 &&
isRemoveCommandAvailable(disks));
Line 120: }
Line 121:
--
To view, visit http://gerrit.ovirt.org/10322
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I445de65ffacc9a6a77f6a350feba46da2d3f3e42
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
