Yair Zaslavsky has posted comments on this change.

Change subject: core : BLL changes for Multi-Tier fencing
......................................................................


Patch Set 10: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
Line 301:             executor = new FencingExecutor(getVds(), 
FenceActionType.Status);
Line 302:             
fenceInvocationResult.setSucceeded(waitForStatus(getVds().getvds_name(), 
getParameters().getAction(), order));
Line 303:             }
Line 304:             finally {
Line 305:                 latch.countDown();
A queue will let us use the same runThread method for all cases.
With future - I will be able to use it only for stop. For start I will need to 
use something else.
F2F will be only on sunday, I'm afraid.
Line 306:             }
Line 307:         }
Line 308:         return fenceInvocationResult;
Line 309:     }


--
To view, visit http://gerrit.ovirt.org/10260
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I82f243593f2b361ca75d97e06f9aede246d4a1b1
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Liron Aravot <lara...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to