Alissa Bonas has posted comments on this change.
Change subject: core: Change class name from action_version_map to
ActionVersionMap.
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAODbFacadeImpl.java
Line 36: parameterSource);
Line 37: }
Line 38:
Line 39: @Override
Line 40: public void addActionVersionMap(ActionVersionMap
action_version_map) {
same as my other comment - it's better to rename the parameter based on java
convention to align with all the renaming
Line 41: MapSqlParameterSource parameterSource =
getCustomMapSqlParameterSource().addValue("action_type",
Line 42:
action_version_map.getaction_type()).addValue("cluster_minimal_version",
Line 43:
action_version_map.getcluster_minimal_version()).addValue("storage_pool_minimal_version",
Line 44: action_version_map.getstorage_pool_minimal_version());
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/ActionGroupDAO.java
Line 26:
Line 27: ActionVersionMap getActionVersionMapByActionType(VdcActionType
action_type);
Line 28:
Line 29: void addActionVersionMap(ActionVersionMap action_version_map);
Line 30:
I'd recommend to rename the parameter itself as well as part of the rename -
currently it's called action_version_map, it'll look better according to java
convention actionVersionMap.
Line 31: void removeActionVersionMap(VdcActionType action_type);
Line 32:
Line 33: List<ActionVersionMap> getAllActionVersionMap();
--
To view, visit http://gerrit.ovirt.org/10042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I453502472d431f3a4358a3f30c59467f590459bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmis...@linux.vnet.ibm.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
