Itamar Heim has posted comments on this change.

Change subject: core: grant UserRole on admin internal for all-in-one use-case
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File 
backend/manager/dbscripts/upgrade/03_02_0150_add_admin_internal_user_role_system.sql
Line 6:    v_user_id uuid ;
Line 7:    v_user_role_id uuid;
Line 8: BEGIN
Line 9:     v_user_id := user_id from users where username = 'admin@internal';
Line 10:     v_user_role_id := '00000000-0000-0000-0001-000000000002';
v_power_user_role would be clearer
Line 11: 
Line 12:     insert into 
permissions(id,role_id,ad_element_id,object_id,object_type_id)
Line 13:         select uuid_generate_v1(), v_user_role_id, v_user_id, 
getGlobalIds('system'), 1
Line 14:         where not exists


....................................................
Commit Message
Line 3: AuthorDate: 2012-12-26 11:01:21 +0200
Line 4: Commit:     Roy Golan <[email protected]>
Line 5: CommitDate: 2012-12-26 11:33:23 +0200
Line 6: 
Line 7: core: grant UserRole on admin internal for all-in-one use-case
s/UserRole/PowerUserRole/
same for rest of commit message?
Line 8: 
Line 9: This fix will let admin@internal use the user portal as a regular user.
Line 10: Super users don't have rights to use the user portal and there is no
Line 11: change in that behaviour.


--
To view, visit http://gerrit.ovirt.org/10379
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib0b51c03b27ad8f9ab0c34c43503b035267ad540
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to