Michael Pasternak has posted comments on this change.
Change subject: API : API Refactoring
......................................................................
Patch Set 7: Looks good to me, approved
(2 inline comments)
well done eli, one tiny comment after that +2.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostNicResource.java
Line 78: @Override
Line 79: public StatisticsResource getStatisticsResource() {
Line 80: EntityIdResolver<Guid> resolver = new EntityIdResolver<Guid>()
{
Line 81: @Override
Line 82: public VdsNetworkInterface lookupEntity(Guid id) throws
BackendFailureException {
please revert the rename of Guid guid => Guid id ^, this class has 'id' class
variable and it's not clear now what var you're actually refer to.
Line 83: return parent.lookupInterface(id.toString());
Line 84: }
Line 85: };
Line 86: HostNicStatisticalQuery query = new
HostNicStatisticalQuery(resolver, newModel(id));
Line 79: public StatisticsResource getStatisticsResource() {
Line 80: EntityIdResolver<Guid> resolver = new EntityIdResolver<Guid>()
{
Line 81: @Override
Line 82: public VdsNetworkInterface lookupEntity(Guid id) throws
BackendFailureException {
Line 83: return parent.lookupInterface(id.toString());
no need for id.toString() as id (class var) already string.
Line 84: }
Line 85: };
Line 86: HostNicStatisticalQuery query = new
HostNicStatisticalQuery(resolver, newModel(id));
Line 87: return inject(new BackendStatisticsResource<HostNIC,
VdsNetworkInterface>(entityType, guid, query));
--
To view, visit http://gerrit.ovirt.org/10096
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic1c7100e31be004fdb325cb00e20042aa1b30df6
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
Gerrit-Reviewer: Alexey Chub <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ohad Basan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
