Arik Hadas has uploaded a new change for review.
Change subject: core: cleanup RunVmCommand#statelessVmTreatment
......................................................................
core: cleanup RunVmCommand#statelessVmTreatment
- Remove unnecessary local field 'p'
- Rename 'tmpVar' field to 'createAllSnapshotsFromVmParameters', so that
the name will be more meaningful
Change-Id: I967b4af546e14a00ac74764458b3cb2c3d946beb
Signed-off-by: Arik Hadas <aha...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
1 file changed, 9 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/31/10331/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
index 3603474..6686dd1 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
@@ -319,14 +319,13 @@
} else {
log.infoFormat("VdcBll.RunVmCommand.RunVmAsStateless - Creating
snapshot for stateless vm {0} - {1}",
getVm().getVmName(), getVm().getId());
- CreateAllSnapshotsFromVmParameters tempVar = new
CreateAllSnapshotsFromVmParameters(getVm().getId(),
- "stateless snapshot");
- tempVar.setShouldBeLogged(false);
- tempVar.setParentCommand(getActionType());
- tempVar.setParentParameters(getParameters());
- tempVar.setEntityId(getParameters().getEntityId());
- CreateAllSnapshotsFromVmParameters p = tempVar;
- p.setSnapshotType(SnapshotType.STATELESS);
+ CreateAllSnapshotsFromVmParameters
createAllSnapshotsFromVmParameters =
+ new CreateAllSnapshotsFromVmParameters(getVm().getId(),
"stateless snapshot");
+ createAllSnapshotsFromVmParameters.setShouldBeLogged(false);
+
createAllSnapshotsFromVmParameters.setParentCommand(getActionType());
+
createAllSnapshotsFromVmParameters.setParentParameters(getParameters());
+
createAllSnapshotsFromVmParameters.setEntityId(getParameters().getEntityId());
+
createAllSnapshotsFromVmParameters.setSnapshotType(SnapshotType.STATELESS);
Map<String, String> values = getVmValuesForMsgResolving();
@@ -340,7 +339,7 @@
createSnapshotsCtx.setStep(createSnapshotsStep);
VdcReturnValueBase vdcReturnValue =
getBackend().runInternalAction(VdcActionType.CreateAllSnapshotsFromVm,
- p,
+ createAllSnapshotsFromVmParameters,
new CommandContext(createSnapshotsCtx,
getCompensationContext(), getLock()));
// setting lock to null in order not to release lock twice
@@ -348,7 +347,7 @@
setSucceeded(vdcReturnValue.getSucceeded());
if (vdcReturnValue.getSucceeded()) {
- getParameters().getImagesParameters().add(p);
+
getParameters().getImagesParameters().add(createAllSnapshotsFromVmParameters);
getReturnValue().getTaskIdList().addAll(vdcReturnValue.getInternalTaskIdList());
// save RunVmParams so we'll know how to run
--
To view, visit http://gerrit.ovirt.org/10331
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I967b4af546e14a00ac74764458b3cb2c3d946beb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
