Allon Mureinik has posted comments on this change.
Change subject: core: adding GetAllDisksByStorageDomainIdQuery
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
1. Please add a test for the DAO
2. Optional but highly advised: a flow test for the query
3. Question: where is this query used? currently, you're introducing dead code,
as it is not called by the UI or REST API
4. some minor implementation issues - see inline,
....................................................
File backend/manager/dbscripts/disk_images_sp.sql
Line 155:
Line 156:
Line 157:
Line 158:
Line 159: Create or replace FUNCTION GetImagesByStorageId(v_storage_id UUID)
any reason this should not be a user query?
Line 160: RETURNS SETOF images_storage_domain_view
Line 161: AS $procedure$
Line 162: BEGIN
Line 163: RETURN QUERY SELECT images_storage_domain_view.*
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java
Line 11:
Line 12: @Override
Line 13: protected void executeQueryCommand() {
Line 14: getQueryReturnValue().setReturnValue(
Line 15:
DbFacade.getInstance().getDiskImageDao().getImagesByStorageId(getParameters().getStorageDomainId()));
use getDbFacade()
Line 16: }
Line 17:
--
To view, visit http://gerrit.ovirt.org/10321
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I017e12a7b3b77ee618f257ab3d719b98bc21eebc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Chris Morrissey <cmorr...@netapp.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
