Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to ChangeVMClusterCommand
......................................................................
Patch Set 19: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVMClusterCommand.java
Line 115: * @return Whether the destination cluster has all networks
configured or not.
Line 116: */
Line 117: private boolean
validateDestinationClusterContainsNetworks(List<VmNetworkInterface> interfaces)
{
Line 118: List<Network> networks =
Line 119:
DbFacade.getInstance().getNetworkDao().getAllForCluster(getParameters().getClusterId());
s/DbFacade.getInstance().getNetworkDao()/getNetworkDao()
Line 120: StringBuilder missingNets = new StringBuilder();
Line 121: for (VmNetworkInterface iface : interfaces) {
Line 122: String netName = iface.getNetworkName();
Line 123: if (netName != null) {
Line 128: break;
Line 129: }
Line 130: }
Line 131: if (!exists) {
Line 132: if (missingNets.length() > 0) {
changing the type of missingNets to list will prevent from this annoying if
block.
a Set<String> would have served better, combined with the StringUtils.join()
instead of StringBuilder.toString().
Line 133: missingNets.append(", ");
Line 134: }
Line 135: missingNets.append(netName);
Line 136: }
--
To view, visit http://gerrit.ovirt.org/9576
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc3dd865ccd99f23862db4f4a37aa5e816db3214
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
