Moti Asayag has posted comments on this change.
Change subject: core: add NetworkLinking to UpdateVmInterfaceCommand
......................................................................
Patch Set 19: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java
Line 118: runVdsCommand(VDSCommandType.UpdateVmInterface,
Line 119: new VmNicDeviceVDSParameters(getVdsId(),
Line 120: getVm(),
Line 121:
getVmNetworkInterfaceDao().get(getInterface().getId()),
Line 122: oldVmDevice));
please add break at the end of this block
Line 123: }
Line 124: }
Line 125: }
Line 126: return true;
Line 124: }
Line 125: }
Line 126: return true;
Line 127: }
Line 128:
s/roperiesRequiringVmUpdateDeviceWereUpdated/properiesRequiringVmUpdateDeviceWereUpdated
Line 129: private boolean roperiesRequiringVmUpdateDeviceWereUpdated() {
Line 130: return (!StringUtils.equals(oldIface.getNetworkName(),
getNetworkName()))
Line 131: || oldIface.isLinked() != getInterface().isLinked();
Line 132: }
--
To view, visit http://gerrit.ovirt.org/9582
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ea914badc716f2908f45c020b53ced423ed23ec
Gerrit-PatchSet: 19
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
