Alon Bar-Lev has posted comments on this change. Change subject: common: remove Config dependency from front-end. ......................................................................
Patch Set 2: > totally agree; I think it's a mistake, we should get config vals from the > query. It is a bit confusing that in case of hot deploy for common, the > front-end won't be affected by it (can be error prone). I don't understand, is the Config object is called at front-end side, or that after deserialization all calls are skipped? If it called, we get only the values of ConfigValues's default, what happens if there is a conflict with the actual config? I don't see any object implementing the IConfigUtilsInterface at front-end side... so I don't understand. > do you want me to write a dependent ui patch that gets 'general' from config > values (cached in the ui)? This will be nice! So we be able to drop one more common class... -- To view, visit http://gerrit.ovirt.org/10263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibcbf08fd77d61a07c83e1e32f0cd67c40ab4cde0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
