Doron Fediuck has posted comments on this change.
Change subject: webamin: hide cpuPin section according to config values
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java
Line 83: GlusterVolumeOptionGroupVirtValue,
Line 84: GlusterVolumeOptionOwnerUserVirtValue,
Line 85: GlusterVolumeOptionOwnerGroupVirtValue,
Line 86: CpuPinningEnabled,
Line 87: CpuPinMigrationEnabled,
OK, re-checked...
I'm still not happy with it, but I prefer this will be handled
in the devel list. So we can let this one in, and check with the
community for the preferred style (which can make it to checkstyle as well).
Line 88: ;
Line 89:
Line 90: public static enum ConfigAuthType {
Line 91: Admin,
--
To view, visit http://gerrit.ovirt.org/9664
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifae4242379136d6dc580d1ee6c78757ff1e7e022
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
