Shireesh Anjal has posted comments on this change.

Change subject: engine, restapi: Move IdQueryParameters to a common package
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IdQueryParameters.java
Line 9: 
Line 10:     private static final long serialVersionUID = -4601447036978553847L;
Line 11:     private Guid id;
Line 12: 
Line 13:     public IdQueryParameters() {
Ah.. :)

I was wondering how this code worked earlier, but then realized that it was 
being used only from restapi layer so far, and never from the UI. Now that 
you're moving it to a generic package, it totally makes sense to introduce the 
default constructor.
Line 14:     }
Line 15: 
Line 16:     public IdQueryParameters(Guid id) {
Line 17:         this.id = id;


--
To view, visit http://gerrit.ovirt.org/10163
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9b919adbfa65169ec4f33a53d13493521d8fd9e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to