Vered Volansky has posted comments on this change.
Change subject: core: add clear message for live snapshot fail
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 273: private boolean canDoSnapshot(VM vm) {
Line 274: //if version is 3.0 - live snapshot is not available, thus if
vm is up snapshot is not possible so it needs to be
Line 275: //checked if it's up or not
Line 276: //if version is 3.1, there is no need to check if vm is up
since in any case snapshot is possible
Line 277: boolean canSnapshot = true;
Sorry, same comments as dependent patch.
At the very least if you don't like returning the if condition, return true or
false straight away. There's no debug advantage here, you can see where you're
returning from and with what.
Line 278: if(!isLiveSnapshotEnabled() && !ImagesHandler.isVmDown(vm)) {
Line 279: //if there is no live snapshot and the vm is up -
snapshot is not possible
Line 280:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_DATA_CENTER_VERSION_DOESNT_SUPPORT_LIVE_SNAPSHOT);
Line 281: canSnapshot = false;
--
To view, visit http://gerrit.ovirt.org/10171
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b6dfc138951baddc991a82a4c9e64f60499428a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alissa Bonas <abo...@redhat.com>
Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
