Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfVm.
......................................................................
Patch Set 5: (1 inline comment)
Basically +2 just a small comment
....................................................
File
backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ovf/OvfVmWriterTest.java
Line 58: Assert.assertEquals(vm.getInterfaces(), newVm.getInterfaces());
Line 59: }
Line 60:
Line 61: private void initInterfaces(VM vm) {
Line 62: List<VmNetworkInterface> interfaceList = new
ArrayList<VmNetworkInterface>();
Why declare the list here if it's only used later?
Also you could simply use Arrays.asList(int1, int2)
Line 63: VmNetworkInterface vmInterface = new VmNetworkInterface();
Line 64: vmInterface.setStatistics(new VmNetworkStatistics());
Line 65: vmInterface.setId(Guid.NewGuid());
Line 66: vmInterface.setName("eth77");
--
To view, visit http://gerrit.ovirt.org/9802
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If739dd0a2140fd714867c79389fe6efe133529ed
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
