ofri masad has posted comments on this change.
Change subject: webadmin: Quota Monitors - webadmin
......................................................................
Patch Set 1: (8 inline comments)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabQuotaView.java
Line 56: public String getValue(Quota object) {
Line 57: return object.getDescription() == null ? "" :
object.getDescription(); //$NON-NLS-1$
Line 58: }
Line 59: }, constants.descriptionQuota(), "120px"); //$NON-NLS-1$
Line 60:
Done
Line 61: // getTable().addColumn(new TextColumnWithTooltip<Quota>() {
Line 62: // @Override
Line 63: // public String getValue(Quota object) {
Line 64: // return object.getStoragePoolName() == null ? "" :
object.getStoragePoolName(); //$NON-NLS-1$
Line 78: for (QuotaVdsGroup quotaVdsGroup :
object.getQuotaVdsGroups()) {
Line 79: allocated += quotaVdsGroup.getMemSizeMB();
Line 80: used += quotaVdsGroup.getMemSizeMBUsage();
Line 81: }
Line 82: }
Done
Line 83: value = (int)(((double)used/allocated) * 100);
Line 84: return allocated < 0 ? -1 : value > 100 ? 100 : value;
Line 85: }
Line 86: },
Line 106: if (allocated < 0) {
Line 107: returnVal = "Unlimited"; //$NON-NLS-1$
Line 108: } else if (value <= 0){
Line 109: returnVal = "0 MB"; //$NON-NLS-1$
Line 110: } else if (value <= 5120) {
Done. (this is 5 GB)
Line 111: returnVal = value + "MB"; //$NON-NLS-1$
Line 112: } else {
Line 113: returnVal =
decimalFormat.format((double)value/1025) + "GB"; //$NON-NLS-1$
Line 114: }
Line 109: returnVal = "0 MB"; //$NON-NLS-1$
Line 110: } else if (value <= 5120) {
Line 111: returnVal = value + "MB"; //$NON-NLS-1$
Line 112: } else {
Line 113: returnVal =
decimalFormat.format((double)value/1025) + "GB"; //$NON-NLS-1$
Done
Line 114: }
Line 115: return returnVal;
Line 116: }
Line 117: },constants.freeMemory(), "80px"); //$NON-NLS-1$
Line 129: for (QuotaVdsGroup quotaVdsGroup :
object.getQuotaVdsGroups()) {
Line 130: allocated += quotaVdsGroup.getVirtualCpu();
Line 131: used += quotaVdsGroup.getVirtualCpuUsage();
Line 132: }
Line 133: }
Done
Line 134: value = (int)(((double)used/allocated) * 100);
Line 135: return allocated < 0 ? -1 : value > 100 ? 100 : value;
Line 136: }
Line 137: },
Line 179: for (QuotaStorage quotaStorage :
object.getQuotaStorages()) {
Line 180: allocated += quotaStorage.getStorageSizeGB();
Line 181: used += quotaStorage.getStorageSizeGBUsage();
Line 182: }
Line 183: }
Done
Line 184: value = (int)((used/allocated) * 100);
Line 185: return allocated < 0 ? -1 : value > 100 ? 100 : value;
Line 186: }
Line 187: },
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/QuotaPercentColumn.java
Line 13: @Override
Line 14: protected String getProgressText(T object) {
Line 15: Integer progressValue = getProgressValue(object);
Line 16: if (progressValue != null && progressValue >= 100) {
Line 17: return "Exceeded"; //$NON-NLS-1$
Done
Line 18: }
Line 19: if (progressValue != null && progressValue < 0) {
Line 20: return "Unlimited"; //$NON-NLS-1$
Line 21: }
Line 16: if (progressValue != null && progressValue >= 100) {
Line 17: return "Exceeded"; //$NON-NLS-1$
Line 18: }
Line 19: if (progressValue != null && progressValue < 0) {
Line 20: return "Unlimited"; //$NON-NLS-1$
Done
Line 21: }
Line 22: return progressValue != null ? progressValue + "%" : "0%";
//$NON-NLS-1$ //$NON-NLS-2$
Line 23: }
Line 24:
--
To view, visit http://gerrit.ovirt.org/10121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39aaf87f084a31b6ff31412030517a2f19bbe1af
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
