Tomas Jelinek has posted comments on this change.
Change subject: userportal: Quota Monitors - userportal
......................................................................
Patch Set 1: (3 inline comments)
You have quite some VerticalPanels used. If possible, please replace them by
FlowPanels with proper styling.
Thank you
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java
Line 310: quotaName.setText(quotaPerUserUsageEntity.getQuotaName());
Line 311: verticalPanel.add(quotaName);
Line 312: verticalPanel.add(vcpuQuotaProgressBar);
Line 313: verticalPanel.setWidth("100%"); //$NON-NLS-1$
Line 314: cpusQuotasList.add(verticalPanel);
this code block (VerticalPanel) seems to be copy pasted three times here - can
you please extract it?
Line 315: }
Line 316:
Line 317: private void addQuotaToMemoryQuotaList(QuotaPerUserUsageEntity
quotaPerUserUsageEntity) {
Line 318: QuotaProgressBar memoryQuotaProgressBar = new
QuotaProgressBar();
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml
Line 11:
type='org.ovirt.engine.ui.userportal.ApplicationResources' />
Line 12:
Line 13: <ui:with field='constants'
type='org.ovirt.engine.ui.userportal.ApplicationConstants' />
Line 14:
Line 15: <ui:style
type="org.ovirt.engine.ui.userportal.section.main.view.tab.extended.SideTabExtendedResourceView.Style">
please adjust the indentation of the CSS
Line 16: .mainPanel {
Line 17: float: left;
Line 18: margin-left: 15px;
Line 19: margin-right: 20px;
....................................................
File
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.ui.xml
Line 1: <?xml version="1.0" encoding="UTF-8"?>
Line 2: <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";>
Line 3: <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder"
xmlns:g="urn:import:com.google.gwt.user.client.ui">
Line 4:
Line 5: <ui:style
type="org.ovirt.engine.ui.userportal.widget.DoublePercentageProgressBar.WidgetStyle">
please remove the tab characters and adjust the indentations
Line 6: .progressBar {
Line 7: width: 95%;
Line 8: }
Line 9:
--
To view, visit http://gerrit.ovirt.org/10122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idbecbf9233704c2cd5e485f3c4158c9a78559218
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
