Michael Pasternak has posted comments on this change.
Change subject: API: [RFE] Add PM Proxy Preferences
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 561: <xs:element ref="network_states" minOccurs="0"/>
Line 562: <xs:element ref="storage_domain_states" minOccurs="0"/>
Line 563: <xs:element ref="template_states" minOccurs="0"/>
Line 564: <xs:element ref="vm_states" minOccurs="0"/>
Line 565: <xs:element ref="vm_pause_details" minOccurs="0"/>
white space
Line 566: <xs:element ref="disk_states" minOccurs="0"/>
Line 567: <xs:element ref="host_nic_states" minOccurs="0"/>
Line 568: <xs:element ref="data_center_states" minOccurs="0"/>
Line 569: <xs:element ref="vm_device_types" minOccurs="0"/>
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/validation/HostValidator.java
Line 10: public class HostValidator implements Validator<Host> {
Line 11:
Line 12: @Override
Line 13: public void validateEnums(Host host) {
Line 14: if (host.isSetPowerManagement()) {
please check here isSetPmProxies() otherwise you can get NPE
Line 15: for (PmProxy proxy :
host.getPowerManagement().getPmProxies().getPmProxy()) {
Line 16: validateEnum(PmProxyType.class, proxy.getPropietary(),
true);
Line 17: }
Line 18: }
--
To view, visit http://gerrit.ovirt.org/9674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If906312ecf028a5db1c9726a407a1643b6c000b7
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
