Mike Kolesnik has posted comments on this change.
Change subject: core: Add NetworkLinking support to OvfTemplate.
......................................................................
Patch Set 5: (2 inline comments)
Basically +2, just some small comments
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java
Line 107: VmNetworkInterface iface = getNetwotkInterface(node);
Line 108: if
(!StringHelper.isNullOrEmpty(node.SelectSingleNode("rasd:ResourceSubType",
_xmlNS).InnerText)) {
Line 109:
iface.setType(Integer.parseInt(node.SelectSingleNode("rasd:ResourceSubType",
_xmlNS).InnerText));
Line 110: }
Line 111: String resourceSubNetworkName =
node.SelectSingleNode("rasd:Connection", _xmlNS).InnerText;
Why not use constant from the OvfProperties?
Line 112: if (StringUtils.isNotEmpty(resourceSubNetworkName)) {
Line 113: iface.setNetworkName(resourceSubNetworkName);
Line 114: } else {
Line 115: iface.setNetworkName(null);
Line 113: iface.setNetworkName(resourceSubNetworkName);
Line 114: } else {
Line 115: iface.setNetworkName(null);
Line 116: }
Line 117: XmlNode linkedNode =
node.SelectSingleNode("rasd:Linked", _xmlNS);
Same question, Why not use constant from the OvfProperties?
Line 118: if (linkedNode != null) {
Line 119:
iface.setLinked(Boolean.valueOf(linkedNode.InnerText));
Line 120: } else {
Line 121: iface.setLinked(true);
--
To view, visit http://gerrit.ovirt.org/9803
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia11fe29f87836e43bd4de240da9160857b144605
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
