Mike Kolesnik has posted comments on this change.
Change subject: core: adding AbstractVmInterfaceCommand
......................................................................
Patch Set 10: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractVmInterfaceCommand.java
Line 15: public AbstractVmInterfaceCommand(T parameters) {
Line 16: super(parameters);
Line 17: }
Line 18:
Line 19: protected boolean activateNic(Guid nicId, PlugAction plugAction) {
If this is activate, why do you need to send plugAction?
Line 20: ActivateDeactivateVmNicParameters activateParameters =
Line 21: createActivateDeactivateParameters(nicId, plugAction);
Line 22: VdcReturnValueBase activateVmNicReturnValue =
Line 23:
Backend.getInstance().runInternalAction(VdcActionType.ActivateDeactivateVmNic,
--
To view, visit http://gerrit.ovirt.org/9667
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15acf7c715703582e96274f4621239b33d263172
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
