Mike Kolesnik has posted comments on this change.
Change subject: core: add NetworkLinking to AddVmTemplateInterfaceCommand
......................................................................
Patch Set 17: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java
Line 83: }
Line 84:
Line 85: boolean unlinkingSupported =
Line 86: Config.<Boolean>
GetValue(ConfigValues.NetworkLinkingSupported,
Line 87:
getVdsGroup().getcompatibility_version().getValue());
How is getVdsGroup() initialized at this point?
Line 88:
Line 89: if (!unlinkingSupported) {
Line 90: if (!getParameters().getInterface().isLinked()) {
Line 91:
addCanDoActionMessage(VdcBllMessages.UNLINKING_IS_NOT_SUPPORTED);
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java
Line 88: @Mock
Line 89: DiskImageDAO diskImageDAO;
Line 90:
Line 91: @Mock
Line 92: VdsGroupDAO vdsGroupDao;
Huh? How is this change related to this patch?
Line 93:
Line 94: @Mock
Line 95: BackendInternal backend;
Line 96:
--
To view, visit http://gerrit.ovirt.org/9565
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id39e63f5061b694457de5918490e08bce3fb962c
Gerrit-PatchSet: 17
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
