Arik Hadas has posted comments on this change. Change subject: core: call Failed to runVms on different thread ......................................................................
Patch Set 1: Verified (1 inline comment) .................................................... Commit Message Line 9: on a busy system we can hit a deadlock in a situation where 2 Vdsmanager Line 10: are failing to run a VM and are notifying each other a FailedToRunVm VDS Line 11: command. Line 12: Line 13: to avoid each one blocking on other's lock the specific action of the proposed solution will reduce the probability of getting into a deadlock in that case, it doesn't prevent it theoretically - so I suggest to replace the term "avoid" Line 14: notifying other hosts is performed in a new thread to try and conclude Line 15: the thread run more quickly and release the lock. Line 16: Line 17: Change-Id: If4d760aa270a3f07b13d1579d7b02c838cb4dd15 -- To view, visit http://gerrit.ovirt.org/10002 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If4d760aa270a3f07b13d1579d7b02c838cb4dd15 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
