Shireesh Anjal has posted comments on this change. Change subject: packaging: Application Mode option in installer ......................................................................
Patch Set 2: (1 inline comment) Just to understand the usage, will the prompt for "Application Mode" show the user what the valid values are? Something like [1=virtonly, 2=glusteronly, 255=both] Also, We should update the flags virt_service and gluster_service on the DB table vds_groups based on the value of Application Mode. .................................................... File packaging/fedora/setup/output_messages.py Line 242: ERR_DB_TEMP_LIST = "Error: failed fetch temp remote DB list. Verify that DB server is up and accessible." Line 243: ERR_DB_UUID = "Error: uuid-ossp extension is not loaded into the DB.\n\ Line 244: Verify with the DB admin that uuid-ossp extension is loaded into newly created databases and \ Line 245: rerun the setup." Line 246: ERR_DB_SET_APPLICATION_MODE = "Error: updating Application mode" Maybe we can say "Error: failed to update Application Mode in DB" Line 247: Line 248: #_updateVdcOptions Line 249: ERR_CANT_FIND_VDC_OPTION_FILE="Unexpected error, Cannot find %s" Line 250: ERR_CANT_FIND_RHEVM_CONFIG_FILE="Unexpected error, Cannot find %s" -- To view, visit http://gerrit.ovirt.org/9991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieba515d2baf3559bf27185c7c6432160551ef172 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Aravinda VK <[email protected]> Gerrit-Reviewer: Aravinda VK <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Ronen Angluster <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
