Allon Mureinik has posted comments on this change. Change subject: engine: Use proper dao api to detect used network ......................................................................
Patch Set 1: (1 inline comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveNetworkCommand.java Line 34: List<VDSGroup> groups = DbFacade.getInstance().getVdsGroupDao().getAllForStoragePool( Line 35: network.getstorage_pool_id().getValue()); Line 36: for (VDSGroup cluster : groups) { Line 37: Network removedNetwork = Line 38: DbFacade.getInstance().getNetworkDao().getByNameAndCluster(network.getName(), cluster.getId()); use getNetworkDao instead of DbFacade.get... Line 39: Line 40: if (removedNetwork != null) { Line 41: canDoActionMessages.add(VdcBllMessages.NETWORK_CLUSTER_NETWORK_IN_USE.toString()); Line 42: return false; -- To view, visit http://gerrit.ovirt.org/9833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I95419986b99c23a741d28929532619f4c56da5a4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches