Liron Aravot has posted comments on this change.
Change subject: restapi,engine: fix usb mapping on update vm call
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java
Line 422: VDSGroup vdsGroup,
Line 423: List<String> messages) {
Line 424: boolean retVal = true;
Line 425: if (usbPolicy == null) {
Line 426:
messages.add(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_USB_POLICY.toString());
why do you think that using toString() is wrong? i think that it's better then
name() as it allows us to change the implementation (if we would want to return
the actual message for example, or just code instead of the name(shorter)) -
using name() for that case would force us to change all calls as it's
final...i'd use toString as it's default to return name() as you stated.. but
that's up to you.
Line 427: retVal = false;
Line 428: } else if (UsbPolicy.ENABLED_NATIVE.equals(usbPolicy)) {
Line 429: if (!Config.<Boolean>
GetValue(ConfigValues.NativeUSBEnabled, vdsGroup.getcompatibility_version()
Line 430: .getValue())) {
--
To view, visit http://gerrit.ovirt.org/9792
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If74bf6ede2fc0f932db8dfcd7951b6bcf90b7744
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
