Alona Kaplan has posted comments on this change.
Change subject: webadmin: Print network description on Remove dialog
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/RemoveNetworksModel.java
Line 45: }
Line 46:
Line 47: } else if (a instanceof Network) {
Line 48: Network network = (Network) a;
Line 49: if (network.getdescription() == null ||
"".equals(network.getdescription().trim())) {
please add //$NON-NLS-1$ at the end of the line. It doesn't compile without it.
Line 50: list.add(network.getName());
Line 51: } else {
Line 52: list.add(StringFormat.format("%1$s (%2$s)",
network.getName(), network.getdescription())); //$NON-NLS-1$
Line 53: }
--
To view, visit http://gerrit.ovirt.org/9791
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7842e5267b084470fc75e8f12bc4666b2f75605
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
