Allon Mureinik has posted comments on this change.
Change subject: core: ImportVm cleanup: parameter hiding
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 209: @Override
Line 210: public boolean eval(VM evalVm) {
Line 211: return
evalVm.getId().equals(getParameters().getVm().getId());
Line 212: }
Line 213: });
Apache commons' CollectionUtil does not work with generic, so I'd have to
uglify the code a bit.
A prefer putting this off until we reach a project-wide decision what framework
we're using (commons, gueva, etc.)
Line 214:
Line 215: if (vm != null) {
Line 216: // At this point we should work with the VM that
was read from
Line 217: // the OVF
....................................................
Commit Message
Line 3: AuthorDate: 2012-11-28 10:43:57 +0200
Line 4: Commit: Allon Mureinik <[email protected]>
Line 5: CommitDate: 2012-12-03 10:58:57 +0200
Line 6:
Line 7: core: ImportVm cleanup: parameter hiding
it's common practice here...
Line 8:
Line 9: Renamed a parameter of an inline class implementation to avoid hiding a
Line 10: variable in enclosing function.
Line 11:
--
To view, visit http://gerrit.ovirt.org/9612
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I408b6ad3bd7407e7a17754a0748bfbc84cb50511
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
