Alon Bar-Lev has posted comments on this change.
Change subject: packaging: initial repo creation
......................................................................
Patch Set 1: (17 inline comments)
Some comments...
For the bootstrap files, I would have provided a diff file, and patch it at
target machine instead of holding the complete files within this repository.
....................................................
File build.sh
Line 1: #!/usr/bin/sh
Line 2: livecd-creator -d -v --config=kickstart/ovirt.ks
--cache=/var/cache/live --fslabel=ovirt-live-`cat VERSION` > iso.log 2>&1 ||
notify-send "Error"
Try to use the following syntax:
livecd-creator \
-d -v \
--config=.... \
--cache=...
> iso.log 2>&1 \
|| notify-send "Error"
....................................................
Commit Message
Line 1: #!/usr/bin/sh
Line 2: livecd-creator -d -v --config=kickstart/ovirt.ks
--cache=/var/cache/live --fslabel=ovirt-live-`cat VERSION` > iso.log 2>&1 ||
notify-send "Error"
Line 3: notify-send "Check ISO"
Line 4
Usually, there should be an empty root commit, because of git limitation of
rebase on first commit, see otopi repository.
Line 4
Line 5
Line 6
Line 7
Line 8
Lines should end at column 78.
....................................................
File config/commit-template.txt
Line 1: <packaging | UX | graphics | usability>: short summary under 50 chars
I don't think we should have this template in every repository out there...
does no damage, but still...
Line 2:
Line 3: Longer description using lines' length under 72 chars.
Line 4:
Line 5: With multiple paragraphs if necessary.
....................................................
File kickstart/ovirt.ks
Line 3: # mailto:desk...@lists.fedoraproject.org
Line 4:
Line 5: %include ovirt-live-base.ks
Line 6:
Line 7: part / --size 16000
trailing space
Line 8: rootpw --iscrypted $1$Idf9Mf5B$lmQBHtDcnO4Xd53vqFWqT.
Line 9: authconfig --enableshadow --passalgo=sha512 --enablefingerprint
Line 10: timezone --utc Asia/Jerusalem
Line 11:
Line 4:
Line 5: %include ovirt-live-base.ks
Line 6:
Line 7: part / --size 16000
Line 8: rootpw --iscrypted $1$Idf9Mf5B$lmQBHtDcnO4Xd53vqFWqT.
trailing space
Line 9: authconfig --enableshadow --passalgo=sha512 --enablefingerprint
Line 10: timezone --utc Asia/Jerusalem
Line 11:
Line 12: %packages
Line 63: set -x -v
Line 64:
Line 65: echo "starting post secion"
Line 66: echo "adding user"
Line 67: /sbin/useradd oVirtuser; echo oVirtuser |passwd oVirtuser --stdin
space after '|'
Line 68: echo "making dir /root/oVirtLiveFiles/"
Line 69: mkdir /root/oVirtLiveFiles/
Line 70: echo "making autostart dir"
Line 71: mkdir -p ~oVirtuser/.config/autostart
Line 83: disable-lock-screen=true
Line 84: FOE
Line 85:
Line 86: # disable updates plugin
Line 87: cat >>
/usr/share/glib-2.0/schemas/org.gnome.settings-daemon.plugins.updates.gschema.override
<< FOE
won't it better to provide tarball and extract it to the rootfs?
Line 88: [org.gnome.settings-daemon.plugins.updates]
Line 89: active=false
Line 90: FOE
Line 91:
Line 127:
Line 128: EOF
Line 129:
Line 130: # Add ovirt repo
Line 131: cat << EOF > /etc/yum.repos.d/ovirt.repo
trailing space
Line 132: [ovirt-stable]
Line 133: name=Stable builds of the oVirt project
Line 134: baseurl=http://ovirt.org/releases/stable/rpm/Fedora/17/
Line 135: enabled=1
Line 201: NM_CONTROLLED=no
Line 202: EOF
Line 203:
Line 204: # Create desktop shortcuts for setup and engine web page
Line 205: cat << EOF > /usr/share/applications/engine-setup.desktop
trailing space
Line 206: [Desktop Entry]
Line 207: Type=Application
Line 208: Encoding=UTF-8
Line 209: Version=1.0
Line 214: X-GNOME-Autostart-Delay=5
Line 215: Icon=/home/oVirtuser/oVirtLiveFiles/ovirt-setup.png
Line 216: EOF
Line 217:
Line 218: cat << EOF > /usr/share/applications/ovirt.desktop
trailing space
Line 219: [Desktop Entry]
Line 220: Type=Application
Line 221: Encoding=UTF-8
Line 222: Version=1.0
Line 244: # Allow wlan* on host (as we're running locally)
Line 245: sed -i -e 's/# hidden_nics = wlan\*,usb\*/hidden_nics = usb\*/'
/etc/vdsm/vdsm.conf
Line 246: %end
Line 247:
Line 248: %post --nochroot
trailing space
Line 249: cp -r oVirtLiveFiles $INSTALL_ROOT/root/
Line 250: %end
Line 251:
Line 252: # Last misc changes here:
....................................................
File kickstart/ovirt-live-base.ks
Line 46:
Line 47: # The point of a live image is to install
Line 48: anaconda
Line 49: isomd5sum
Line 50: # grub-efi and grub2 and efibootmgr so anaconda can use the right one
on install.
trailing space
Line 51: grub-efi
Line 52: grub2
Line 53: efibootmgr
Line 54:
Line 64:
picture-uri='file:///home/oVirtuser/oVirtLiveFiles/ovirt-wallpaper-16:9.jpg'
Line 65: EOF
Line 66:
Line 67: # FIXME: it'd be better to get this installed from a package
Line 68: cat > /etc/rc.d/init.d/livesys << EOF
Can't you simply use a file and not escape all the content?
Line 69: #!/bin/bash
Line 70: #
Line 71: # live: Init script for live image
Line 72: #
....................................................
File oVirtLiveFiles/engine-setup-yad.sh
Line 1: #! /bin/bash
why use bash specific?
Line 2: # TODO
Line 3:
Line 4:
Line 5: action=$(yad --entry \
Line 1: #! /bin/bash
Line 2: # TODO
trailing space
Line 3:
Line 4:
Line 5: action=$(yad --entry \
Line 6: --title "oVirt installation" \
Line 27:
Line 28: case $action in
Line 29: automatic*) cmd="sudo /usr/bin/engine-setup
--answer-file=/home/oVirtuser/oVirtLiveFiles/ovirt-answer" ;;
Line 30: interactive*) cmd="gnome-terminal --command=\"sudo
/usr/bin/engine-setup\";sleep 20" ;;
Line 31: *) exit 1 ;;
trailing space
Line 32: esac
Line 33:
Line 34: echo "excecuting $cmd"
Line 35: $cmd
--
To view, visit http://gerrit.ovirt.org/9733
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I66cca8f5d5abaa710f054c59043ff6363b68256f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-live
Gerrit-Branch: master
Gerrit-Owner: Moran Goldboim <mgold...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
