Moti Asayag has posted comments on this change.
Change subject: tools: Fixing npe at notification service log
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java
Line 175: Transport.send(msg);
Line 176: }
Line 177: } catch (MessagingException mex) {
Line 178: StringBuilder errorMsg = new StringBuilder("Failed to
send message ");
Line 179: if (from != null) {
Since you already put an effort on improving this log readability, please add
a check for StringUtils.isNotBlank prior to printing the "from.toString()"
value and for the rest of the parametes replace the null check with
"StringUtils.isNotBlank".
Line 180: errorMsg.append(" from " + from.toString());
Line 181: }
Line 182: if (recipient != null) {
Line 183: errorMsg.append(" to " + recipient);
--
To view, visit http://gerrit.ovirt.org/9726
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
