Gilad Chaplik has posted comments on this change. Change subject: webadmin: Avoid duplicate server queries ......................................................................
Patch Set 2: (1 inline comment) .................................................... File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java Line 201: pendingRequests.remove(callback.getQueryKey()); Line 202: RunQuery(wrapper.getQueryType(), wrapper.getParameters(), wrapper.getCallback()); Line 203: } else { Line 204: currentRequests.remove(callback.getQueryKey()); Line 205: } Done, it took me a while to get you :) seems that the first line in the method should remove from current Line 206: } Line 207: } Line 208: Line 209: @Override -- To view, visit http://gerrit.ovirt.org/9554 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I483a1c449f1eb2e9820464dbaf0a686f90923bb6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches