Muli Salem has posted comments on this change.
Change subject: engine: Require permissions for configure DC network
......................................................................
Patch Set 3: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveNetworkCommand.java
Line 60: @Override
Line 61: public AuditLogType getAuditLogTypeValue() {
Line 62: return getSucceeded() ? AuditLogType.NETWORK_REMOVE_NETWORK :
AuditLogType.NETWORK_REMOVE_NETWORK_FAILED;
Line 63: }
Line 64:
It seems this file should not be part of the patch.
....................................................
Commit Message
Line 5: CommitDate: 2012-11-29 23:40:51 +0200
Line 6:
Line 7: engine: Require permissions for configure DC network
Line 8:
Line 9: The UpdateNetworkCommand and RemoveNetowrkCommand were modified
sed RemoveNetowrkCommand/RemoveNetworkCommand/
Line 10: to require permission on the target network for updating it.
Line 11:
Line 12: AddNetworkCommand still requires permission on the Data-Center.
Line 13:
--
To view, visit http://gerrit.ovirt.org/9537
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I739bc5f4f76b0c8c712cd604ee0b4a3987a16fd3
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
