Doron Fediuck has posted comments on this change.
Change subject: core: Fix empty quota in updateVM pass
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java
Line 362: || getVm().getstatus() == VMStatus.PoweringDown) {
Line 363: list.add(new
QuotaSanityParameter(getParameters().getVmStaticData().getQuotaId(), null));
Line 364: } else {
Line 365: if (getParameters().getVmStaticData().getQuotaId() == null
Line 366: ||
getParameters().getVmStaticData().getQuotaId().equals(NGuid.Empty)
So this is allowing empty quota in contradiction to what the bz says?
Or how will you represent the empty guid in the selection box?
Also, iirc, in the past we said that no quota will be replaced by the first
option from available quotas in the UI. What happened there?
Line 367: ||
!getParameters().getVmStaticData().getQuotaId().equals(getVm().getQuotaId())) {
Line 368: list.add(new
QuotaVdsGroupConsumptionParameter(getVm().getQuotaId(),
Line 369: null,
Line 370: QuotaConsumptionParameter.QuotaAction.RELEASE,
--
To view, visit http://gerrit.ovirt.org/9654
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b4c782c7c2dd3a70a19e8ed82ab5e180495eb6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
