Alex Lourie has posted comments on this change. Change subject: Packaging: remove CABaseDirectory from engine-config-install.properties ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 6: Line 7: Packaging: remove CABaseDirectory from engine-config-install.properties Line 8: Line 9: The parameter CABaseDirectory in engine-config-install.properties is Line 10: not being used anymore and therefore should be remove from the setup. 'remove' -> 'removed' I would also update a comment a bit, to something like: The parameter ... can no longer be updated with the engine-config tool and as such needs to be removed from setup. Line 11: Line 12: Bug-URL : https://bugzilla.redhat.com/show_bug.cgi?id=882874 Line 13: Change-Id: I7cae8e0f6c6769dae1eb086c0d89ec58988573c7 -- To view, visit http://gerrit.ovirt.org/9659 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cae8e0f6c6769dae1eb086c0d89ec58988573c7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ohad Basan <oba...@redhat.com> Gerrit-Reviewer: Alex Lourie <alou...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Moran Goldboim <mgold...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ohad Basan <oba...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
