Tomas Jelinek has posted comments on this change.
Change subject: userportal,webadmin: switch tab with space key
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/tab/DialogTabPanel.java
Line 48: tab.addKeyUpHandler(new KeyUpHandler() {
Line 49: @Override
Line 50: public void onKeyUp(KeyUpEvent event) {
Line 51: // if space key was pressed
Line 52: if (32 == event.getNativeKeyCode()) {
please extract this magic number to a named constant
Line 53: switchTab(tab);
Line 54: }
Line 55: }
Line 56: });
--
To view, visit http://gerrit.ovirt.org/9637
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e727e81b0dc0e96dd81a22b338a2362cb46e7c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Einav Cohen <eco...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
