Eli Mesika has posted comments on this change. Change subject: engine: engine-config cleanup 2.2 IsNeedSupportForOldVgAPI ......................................................................
Patch Set 5: (1 inline comment) .................................................... File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql Line 666: select fn_db_delete_config_value('VdsErrorsFileName','general'); Line 667: select fn_db_delete_config_value('VM64BitMaxMemorySizeInMB','general'); Line 668: select fn_db_delete_config_value('LogVdsRegistration','general'); Line 669: select fn_db_delete_config_value('IsNeedSupportForOldVgAPI','2.2'); Line 670: select fn_db_delete_config_value('IsNeedSupportForOldVgAPI','3.0'); can be unified after your general function supporting comma separated versions is pushed Line 671: ------------------------------------------------------------------------------------ Line 672: -- Split config section Line 673: -- The purpose of this section is to treat config option that was once Line 674: -- general, and should now be version-specific. -- To view, visit http://gerrit.ovirt.org/9485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I373eb6607744b44069ee59adaae1625fc6f676c9 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches