Oved Ourfali has posted comments on this change. Change subject: restapi: Privileged user cannot create VM via API (#876460) ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) One comment regarding the user-query. Other than that the patch looks great! Oved .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java Line 64: GetVdsCertificateSubjectByVmId(VdcQueryAuthType.User), Line 65: GetAllVdsGroups(VdcQueryAuthType.User), Line 66: GetVdsGroupByVdsGroupId(VdcQueryAuthType.User), // needed when updating VM Line 67: GetVdsGroupById(VdcQueryAuthType.User), Line 68: GetVdsGroupByName(VdcQueryAuthType.User), When doing that you also need to make the query by "filter-aware". Look at other user queries for example on how to do that. Line 69: IsVdsGroupWithSameNameExist, Line 70: GetVdsGroupsByStoragePoolId(VdcQueryAuthType.User), Line 71: Line 72: // Certificate -- To view, visit http://gerrit.ovirt.org/9248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
