Michael Pasternak has posted comments on this change.
Change subject: restapi: Extend block domain - override_luns
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 705: parameterType: StorageDomain
Line 706: signatures:
Line 707: - mandatoryArguments: {}
Line 708: optionalArguments: {storagedomain.name: 'xs:string'}
Line 709: - mandatoryArguments:
{storagedomain.storage.logical_unit--COLLECTION: {logical_unit.address:
'xs:string',
there is no mandatory parameters in this use-case of update(), split this in
two parameters_sets (overloads),where in first one only name (maybe description
as well) and they're optional, and in second one SD related params.
Line 710: logical_unit.port: 'xs:int', logical_unit.target:
'xs:string', logical_unit.username: 'xs:string', logical_unit.password:
'xs:string',
Line 711: logical_unit.serial: 'xs:string', logical_unit.vendor_id:
'xs:string', logical_unit.product_id: 'xs:string',
Line 712: logical_unit.lun_mapping: 'xs:int', logical_unit.portal:
'xs:string', logical_unit.paths: 'xs:int', logical_unit.id: 'xs:string'}}
Line 713: optionalArguments: {storagedomain.name: 'xs:string',
storagedomain.storage.override_luns: 'xs:boolean'}
--
To view, visit http://gerrit.ovirt.org/9344
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I492876d33913e8ddc88c30e5189e52bf58361fd1
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
