Allon Mureinik has uploaded a new change for review. Change subject: core: ImportVm cleanup: canDoActionXXX conventions ......................................................................
core: ImportVm cleanup: canDoActionXXX conventions Fixed naming conventions in the canDoActionXXX methods to adhere to Java conventions. Change-Id: I88f41893fd50d5420b567d9af98ac85e5c808b96 Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/9624/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java index f327346..b8e2124 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java @@ -130,7 +130,7 @@ List<String> canDoActionMessages = getReturnValue().getCanDoActionMessages(); Map<Guid, storage_domains> domainsMap = new HashMap<Guid, storage_domains>(); - if (!canDoAction_beforeCloneVm(canDoActionMessages, domainsMap)) { + if (!canDoActionBeforeCloneVm(canDoActionMessages, domainsMap)) { return failCanDoActionWithType(); } @@ -138,7 +138,7 @@ initImportClonedVm(); } - if (!canDoAction_afterCloneVm(canDoActionMessages, domainsMap)) { + if (!canDoActionAfterCloneVm(canDoActionMessages, domainsMap)) { return failCanDoActionWithType(); } @@ -164,7 +164,7 @@ } } - private boolean canDoAction_beforeCloneVm(List<String> canDoActionMessages, Map<Guid, storage_domains> domainsMap) { + private boolean canDoActionBeforeCloneVm(List<String> canDoActionMessages, Map<Guid, storage_domains> domainsMap) { if (getVm() != null) { setDescription(getVmName()); @@ -278,7 +278,7 @@ canDoActionMessages); } - private boolean canDoAction_afterCloneVm(List<String> canDoActionMessages, Map<Guid, storage_domains> domainsMap) { + private boolean canDoActionAfterCloneVm(List<String> canDoActionMessages, Map<Guid, storage_domains> domainsMap) { VM vm = getParameters().getVm(); // check that the imported vm guid is not in engine -- To view, visit http://gerrit.ovirt.org/9624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I88f41893fd50d5420b567d9af98ac85e5c808b96 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches