Allon Mureinik has posted comments on this change.
Change subject: core: cleanup and delete EnumCompat
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java
Line 137: * Enum of the disk's type, which defines which underlying
storage details will be contained in the {@link Disk}
Line 138: * object instance.
Line 139: */
Line 140: public enum DiskStorageType implements Identifiable {
Line 141: // FIXME add ids and remove the ordinal impl of getValue
why?
an Enum is nothing but a list of ordinal constants.
Why would you want another ID?
Line 142: IMAGE,
Line 143: LUN;
Line 144:
Line 145: @Override
--
To view, visit http://gerrit.ovirt.org/9516
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0383ea74495f74ff1727561644017d8b3bae7e6f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
