Tomas Jelinek has posted comments on this change. Change subject: webadmin: fix focus traversal in make template ......................................................................
Patch Set 2: (1 inline comment) One minor comment about a mistake in commit message. Otherwise it seems great, so as soon as it will be fixed I will merge it. .................................................... Commit Message Line 12: - the focus traversal also include the "ok" and "cancel" buttons Line 13: Line 14: This mechanism can be extended in the future to fix the focus traversal Line 15: in other dialogs. it is especially easy to extend it to other similar Line 16: popup dialogs (that subclass AbstractModelBoundWidgetPopupWidget) - all actually it is called AbstractModelBoundPopupWidget Line 17: we need is that its widget will override "setTabIndexes" method and Line 18: define a custom focus order to its components. Line 19: Line 20: Change-Id: I82233e8d136154e942d1ffce8e6f831ddfbfb3fb -- To view, visit http://gerrit.ovirt.org/9514 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82233e8d136154e942d1ffce8e6f831ddfbfb3fb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
