Roy Golan has posted comments on this change.
Change subject: engine: VM Linux Boot options aren't parsing properly
......................................................................
Patch Set 1: (1 inline comment)
+2 backend validation
why not trim the params before sending them?
why not block param and initrd fields if the kernel path is empty?
minor formatting comment - pls use the engine convention for braces
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
Line 1949:
getInitrd_path().getInvalidityReasons().add(cannotStartOrEndWithWhitespaceMsg);
Line 1950: }
Line 1951:
Line 1952: if ((kernelParams.length() > 0 || initrdPath.length() >
0) && kernelPath.length() == 0)
Line 1953: {
mixed formatting. pls make every thing by the engine convention.
Line 1954: boolean kernelParamInvalid = false;
Line 1955: boolean inetdPathInvalid = false;
Line 1956:
Line 1957: if (kernelParams.length() > 0)
--
To view, visit http://gerrit.ovirt.org/9550
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9ccb4fc0b807c77bc17cfe02903341cdf4e51d54
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
