Alon Bar-Lev has posted comments on this change.
Change subject: Updated spec file to follow packaging guide lines (BZ#772608)
......................................................................
Patch Set 11: (2 inline comments)
....................................................
File Makefile.am
Line 16: install-exec-hook:
Line 17: $(MKDIR_P) $(DESTDIR)/$(datadir)/ovirt-guest-agent
Line 18: $(LN_S) /usr/bin/consolehelper
$(DESTDIR)/$(datadir)/ovirt-guest-agent/ovirt-locksession
Line 19: $(LN_S) /usr/bin/consolehelper
$(DESTDIR)/$(datadir)/ovirt-guest-agent/ovirt-shutdown
Line 20: $(LN_S) /usr/bin/consolehelper
$(DESTDIR)/$(datadir)/ovirt-guest-agent/ovirt-hibernate
what happened to $(bindir)?
....................................................
File ovirt-guest-agent.spec
Line 106:
Line 107: # Update timestamps on Python files in order to avoid differences
between
Line 108: # .pyc/.pyo files.
Line 109: touch -r %{SOURCE0} %{buildroot}%{_datadir}/ovirt-guest-agent/*.py
Line 110:
Why do we need this?
Line 111: install -d %{buildroot}%{_localstatedir}/log/ovirt-guest-agent
Line 112: install -d %{buildroot}%{_localstatedir}/lock/subsys/ovirt-guest-agent
Line 113:
Line 114: %pre common
--
To view, visit http://gerrit.ovirt.org/8715
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec350b4027bffff8dff73db7986020fdc48261cd
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-guest-agent
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Gal Hammer <gham...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
