Juan Hernandez has posted comments on this change.
Change subject: bootstrap: rewrite bootstrap using the new ovirt-host-deploy
package
......................................................................
Patch Set 15: (4 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 126: try {
Line 127: log.infoFormat(
Line 128: "Before Installation host {0}, {1}",
Line 129: getVds().getId(),
Line 130: getVds().getvds_name()
Shouldn't these two lines ^ be aligned to the same level?
Line 131: );
Line 132:
Line 133: T parameters = getParameters();
Line 134: installer = new VdsDeploy(getVds());
Line 157: "Not handled VDS type: %1$s",
Line 158: getVds().getvds_type()
Line 159: )
Line 160: );
Line 161: }
The formatting of this ^ switch statement is inconsistent.
Line 162: installer.execute();
Line 163: if (getVds().getstatus() == VDSStatus.Reboot) {
Line 164: RunSleepOnReboot();
Line 165: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
Line 146: )
Line 147: );
Line 148: }
Line 149:
Line 150: log.infoFormat("Assigning unique id {0} to Host {1}",
_vds.gethost_name(), vdsmid);
The arguments are swapped.
Line 151: _vds.setUniqueId(vdsmid);
Line 152:
Line 153: TransactionSupport.executeInNewTransaction(new
TransactionMethod<Void>() {
Line 154: @Override
Line 562: LocalConfig.getInstance().getLogDir(),
Line 563: String.format(
Line 564: "%1$s%2$sovirt-%3$s-%4$s.log",
Line 565: "host-deploy",
Line 566: System.getProperty("file.separator"),
File.separator
Line 567: new SimpleDateFormat("yyyyMMddHHmmss").format(
Line 568: Calendar.getInstance().getTime()
Line 569: ),
Line 570: _vds.gethost_name()
--
To view, visit http://gerrit.ovirt.org/9175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If78c62601231f4729ca95da7653907b37856d672
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
