Moti Asayag has posted comments on this change.
Change subject: core: adding "UnlinkingSupported" to vdc_options.
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1558: @TypeConverterAttribute(Integer.class)
Line 1559: @DefaultValueAttribute("300")
Line 1560: GlusterRefreshRateHeavy(396),
Line 1561:
Line 1562: @Reloadable
please remove the @Reloadable annotation.
We shouldn't allow modifying this property - is it determined by the engine
version.
HotplugSupport @Reloadable annotation should be removed as well.
Line 1563: @TypeConverterAttribute(Boolean.class)
Line 1564: @DefaultValueAttribute("false")
Line 1565: UnlinkingSupported(397),
Line 1566:
--
To view, visit http://gerrit.ovirt.org/9448
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I72e8fd298db5672b5af9bb6475020ac181b00f39
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
