Allon Mureinik has posted comments on this change. Change subject: bootstrap: make approve command respect installation failure ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 7: bootstrap: make approve command respect installation failure Line 8: Line 9: Current implementation assumes success at all results, which is invalid. Line 10: Line 11: Do not use parent member if there is a method to access it. you can also generalize all the fixes you want as a "code doesn't do what I want" patch :-) IMHO, these are two distinct issues. But it's not a biggie. As you can see, I +1ed it. Line 12: Line 13: Change-Id: Iab010f40007ac11dd909350f60b6db1880edbf7f -- To view, visit http://gerrit.ovirt.org/9443 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab010f40007ac11dd909350f60b6db1880edbf7f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
