Eli Mesika has posted comments on this change. Change subject: engine: Remove a dead code from VdsManager ......................................................................
Patch Set 1: Looks good to me, approved (2 inline comments) Please fix typos in the commit message before merge .................................................... Commit Message Line 5: CommitDate: 2012-11-21 09:53:19 +0200 Line 6: Line 7: engine: Remove a dead code from VdsManager Line 8: Line 9: The following condition was removed from VdsManager because it will necer be true. necer=>never Line 10: _vdsUpdater is cleaned usually before realising a lock inside a VdsManager and exit Line 11: of critical section. Line 12: The method UpdateVmDynamic is usually called under lock of VdsManger, so always _vdsUpdater Line 13: will be null. Line 10: _vdsUpdater is cleaned usually before realising a lock inside a VdsManager and exit Line 11: of critical section. Line 12: The method UpdateVmDynamic is usually called under lock of VdsManger, so always _vdsUpdater Line 13: will be null. Line 14: The method from VdsUpdateRuntimeInfo not in use anymore - tat's why removed. tat's =>that's Line 15: Line 16: Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb -- To view, visit http://gerrit.ovirt.org/9374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
