Oved Ourfali has posted comments on this change.
Change subject: tools: Don't ask for password, before DNS SRV records are
returned.
......................................................................
Patch Set 2: (2 inline comments)
minor comments
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java
Line 35: ldapProviderType;
Line 36: }
Line 37:
Line 38: public KerberosConfigCheck(DnsSRVResult ldapDnsResult) {
Line 39: this.ldapDnsResult = ldapDnsResult;
Please add another constructor instead of passing null all the time.
Line 40: }
Line 41:
Line 42: // This function gets the username and adjusts it doing the
following:
Line 43: // 1. If the username contains @, for example:
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResultEnum.java
Line 33: "Operation failed due to exception. Details: %1$s",
Line 34: 20),
Line 35: FAILURE_READING_PASSWORD_FILE("failed reading password from
password file", 21),
Line 36: EMPTY_PASSWORD_FILE("password file is empty", 22),
Line 37: NO_LDAP_SERVERS_FOR_DOMAIN("No ldap servers can be obtained for
domain %1$s",23),
write ldap in uppercase.
Line 38: NO_KDC_SERVERS_FOR_DOMAIN("No KDC can be obtained for domain
%1$s",24);
Line 39: private String detailedMessage;
Line 40: private final int exitCode;
Line 41:
--
To view, visit http://gerrit.ovirt.org/9349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c5132300eb1f1fd94f771cab17efe5246dbeca8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
